Lisätään generated-sarake hakemuksen ykkösyksikölle #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gekkio
commented
Sep 6, 2024
•
Gekkio
commented
- Saraketta ei vielä käytetä missään mutta kyselyitä voidaan vaihtaa käyttämään sitä pikku hiljaa
- Sarake pakottaa FK:n ykkösyksikölle
This information is often needed and currently it needs to be always fetched from inside the JSON document.
Wnt
reviewed
Sep 17, 2024
| @@ -11,6 +11,7 @@ flyway.password=flyway | |||
| # Runtime properties passed to schema migrations (to avoid hardcoded role names) | |||
| flyway.placeholders.application_user=evaka_application_local | |||
| flyway.placeholders.migration_user=evaka_migration_local | |||
| flyway.cleanDisabled=false | |||
There was a problem hiding this comment.
Miksi tämä on vaihdettu? Flywayn dokumentaation mukaan tämän asettaminen falseksi tuotantoympäristössä voi olla "career limiting move"
There was a problem hiding this comment.
gradle.properties vaikuttaa vain gradlen flyway-plugariin, eikä tiedostoa edes ole docker-kontissa missä tuotantoympäristöissä ajetaan Flyway osana sovelluksen käynnistystä
Wnt
approved these changes
Sep 23, 2024
patari
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.